This repository was archived by the owner on Oct 27, 2020. It is now read-only.
[MHD-128] reject cases that are strictly invalid#287
Open
theunkn0wn1 wants to merge 1 commit intoFuelRats:developfrom
Open
[MHD-128] reject cases that are strictly invalid#287theunkn0wn1 wants to merge 1 commit intoFuelRats:developfrom
theunkn0wn1 wants to merge 1 commit intoFuelRats:developfrom
Conversation
|
Id change the output string to something more descriptive. Something like 'Invalid Announcement, missing (Case Number|System|Platform)' Otherwise its just going to confuse people not familiar with the process. |
Contributor
Author
|
Given this is a fail-safe measure, and only is triggered when some other component glares at announcer goes wrong, all end users really need to know is something went wrong (strictly invalid) and that the dispatch needs to manually inject the case. I feel specifying exactly what went wrong would only make the message longer and thus clutter the channel. |
Member
|
Given that the announcer only forwards what the client plugin tells it, you can turn that glare of yours elsewhere. :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves MHD-128.
Specifically, mecha will now reject any incoming announcement that is strictly invalid, ie the system, client, or platform are null.